Bump certbot-azure-dns version #4816
Conversation
|
Is there a way to get access to the build logs? |
|
The build failed CI due to recent major postgres releases. If you want to rebase now, hopefully it should pass. |
|
In case you missed it, the plugins json file has moved here. |
|
Can you confirm this build is working as expected? Can we also find another person to confirm this build is working? |
jc21
added
the
requires-verification
|
I just tested it. The build isn't working out of the box. It is necessary to manually set a specific dependency version, since the certbot-azure-dns plugin is not compatible with There are multiple PRs in the dns plugin repo that would fix that issue: But it seems none of them has been reviewed yet. I'm not sure if the project is still maintained, the last change was almost a year ago... Should I mark this PR here as draft until something happens on the related project? If someone else wants to apply the workaround: |
backend/certbot/dns-plugins.json
Outdated
| "package_name": "certbot-dns-azure", | ||
| "version": "~=1.2.0", | ||
| "version": "~=2.6.1", | ||
| "dependencies": "", |
There was a problem hiding this comment.
You can add your azure-mgmt-dns dependency in this line and lock it to a version.
"dependencies": "azure-mgmt-dns==9.0.0",
There was a problem hiding this comment.
I added the suggestion and will try it, as soon as the CI build is ready.
|
Docker Image for build 7 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
|
I tested the new build and can confirm, that it is now working without manual interaction. From my perspective the PR can be merged. |
2 participants
I need the DNS delegation feature from the azure dns plugin which isn't available in the old version. Therefore I suggest updating the lib to the latest stable version.